Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added extend/extend_unchecked for MutableBooleanArray #478

Merged
merged 6 commits into from
Sep 30, 2021
Merged

Added extend/extend_unchecked for MutableBooleanArray #478

merged 6 commits into from
Sep 30, 2021
+141 −17

Conversation

VasanthakumarV
Copy link
Contributor

This PR adds TrustedLen-based extend and extend_unchecked methods for MutableBooleanArray.

I have mostly followed the implementation for MutablePrimitiveArray.

@codecov
Copy link

codecov bot commented Sep 30, 2021 •
edited
Loading

Codecov Report

Merging #478 (cf1adcb) into main (94fd267) will increase coverage by 0.08%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   80.02%   80.11%   +0.08%     
==========================================
  Files         371      373       +2     
  Lines       22841    22982     +141     
==========================================
+ Hits        18279    18411     +132     
- Misses       4562     4571       +9
Impacted Files Coverage Δ
src/array/boolean/mutable.rs 85.54% <89.47%> (+0.31%) ⬆️
tests/it/array/boolean/mutable.rs 100.00% <100.00%> (ø)
src/array/growable/mod.rs 44.44% <0.00%> (-3.56%) ⬇️
src/ffi/mod.rs 100.00% <0.00%> (ø)
src/array/mod.rs 54.62% <0.00%> (ø)
src/types/mod.rs 22.22% <0.00%> (ø)
src/io/csv/mod.rs 0.00% <0.00%> (ø)
src/io/avro/mod.rs 0.00% <0.00%> (ø)
src/io/json/mod.rs 100.00% <0.00%> (ø)
src/record_batch.rs 44.44% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fd267...cf1adcb. Read the comment docs.

jorgecarleitao
jorgecarleitao approved these changes Sep 30, 2021
View reviewed changes
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, beautiful. Thank you very much!

Left some suggestions (the Safety should be applied to every usage of unsafe), but otherwise ready to go.

src/array/boolean/mutable.rs Show resolved Hide resolved
src/array/boolean/mutable.rs Show resolved Hide resolved
tests/it/array/boolean/mutable.rs Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title Add extend/extend_unchecked for MutableBooleanArray Added extend/extend_unchecked for MutableBooleanArray Sep 30, 2021
@jorgecarleitao jorgecarleitao merged commit 3e07d5f into jorgecarleitao:main Sep 30, 2021
@jorgecarleitao jorgecarleitao added the feature A new feature label Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jorgecarleitao jorgecarleitao jorgecarleitao approved these changes

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasanthakumarV @jorgecarleitao